Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send method arguments with numerics to the second pass #6700

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Nov 6, 2024

Description

This PR brings back encode/decode buffer ownership tests and closes #6567.

The original issue was that an error in the CI file was hiding that these tests were not compiling anymore.

IR generation now also tests the expression and the variant type match, giving a better error than before.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj requested review from a team as code owners November 6, 2024 15:22
@xunilrj xunilrj self-assigned this Nov 6, 2024
Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #6700 will not alter performance

Comparing xunilrj/better-type-inf-numerics (ff196eb) with master (cbf0c62)

Summary

✅ 22 untouched benchmarks

@xunilrj xunilrj force-pushed the xunilrj/better-type-inf-numerics branch from 6bcd1d2 to ff196eb Compare November 12, 2024 10:27
@xunilrj xunilrj merged commit ae9f172 into master Nov 12, 2024
40 checks passed
@xunilrj xunilrj deleted the xunilrj/better-type-inf-numerics branch November 12, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing forc unit test: ok_vec_buffer_ownership
3 participants