Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow to run linter and tests on pull requests #56

Closed
JakeLo123 opened this issue Apr 5, 2024 · 0 comments · Fixed by #57
Closed

Add workflow to run linter and tests on pull requests #56

JakeLo123 opened this issue Apr 5, 2024 · 0 comments · Fixed by #57
Assignees
@JakeLo123
Labels
DX general issue not necessarily an observable bug, but needs change

Comments

@JakeLo123
Copy link
Collaborator

Add workflow to run linter and tests on pull requests

Description

It would be nice to have this workflow get dispatched on pull_request for extra safety and consistency. These run pre-commit, but that can be bypassed with --no-verify or on rebase in some cases.

Community guidelines

All issues filed in this repository must abide by the FusionAuth community guidelines.
@JakeLo123 JakeLo123 added the general issue not necessarily an observable bug, but needs change label Apr 5, 2024
@JakeLo123 JakeLo123 self-assigned this Apr 5, 2024
@JakeLo123 JakeLo123 mentioned this issue Apr 5, 2024
Merged
1 task
@JakeLo123 JakeLo123 linked a pull request Apr 8, 2024 that will close this issue
Adding lint-and-test workflow to dispatch on pull requests #57
Merged
1 task
@linear linear bot added the DX label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JakeLo123 JakeLo123

Labels
DX general issue not necessarily an observable bug, but needs change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding lint-and-test workflow to dispatch on pull requests FusionAuth/fusionauth-javascript-sdk
1 participant
@JakeLo123