Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lint-and-test workflow to dispatch on pull requests #57

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

JakeLo123
Copy link
Collaborator

@JakeLo123 JakeLo123 commented Apr 5, 2024

What is this PR and why do we need it?

#56 - adds lint-and-test workflow that will dispatch itself on pull requests into main.

Every PR into main will have to pass unit tests plus a lint and format check before merge.

Pre-Merge Checklist (if applicable)

  • Unit and Feature tests have been added/updated for logic changes, or there is a justifiable reason for not doing so.

@JakeLo123 JakeLo123 self-assigned this Apr 5, 2024
@JakeLo123 JakeLo123 force-pushed the dispatch-lint-test-workflow-on-pull-request branch from 7c58fdd to e2af429 Compare April 5, 2024 17:23
@JakeLo123 JakeLo123 added the general issue not necessarily an observable bug, but needs change label Apr 5, 2024
@JakeLo123 JakeLo123 linked an issue Apr 8, 2024 that may be closed by this pull request
@JakeLo123 JakeLo123 merged commit ffc50cf into main Apr 8, 2024
3 checks passed
@JakeLo123 JakeLo123 deleted the dispatch-lint-test-workflow-on-pull-request branch April 8, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general issue not necessarily an observable bug, but needs change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add workflow to run linter and tests on pull requests
2 participants