Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

46 Add postLogoutRedirectUri Param Handling #103

Merged
merged 1 commit into from
May 17, 2024

Conversation

BriDavidson
Copy link
Collaborator

@BriDavidson BriDavidson commented May 17, 2024

What is this PR and why do we need it?

#46

This adds the postLogoutRedirectUri param into the SDK config and updates logic for SDK to redirect users to the optionally defined postLogoutRedirectUri, if this does not exist the user should be brought to the redirectUri by default.

To Test:

  1. Run unit tests to ensure updated urlHelper Tests pass when postLogoutRedirectUri param is passed in
  2. Define a postLogoutRedirectUri in the config of the consuming application and ensure the url is accepted by adding it to the application configuration in the admin dashboard.
  3. Log In to the consuming application
  4. Log Out and ensure that when postLogoutRedirectUri is defined that redirect to the defined param is successful, if it is not defined ensure that redirect to the redirectUri defaults

Pre-Merge Checklist (if applicable)

  • Unit and Feature tests have been added/updated for logic changes, or there is a justifiable reason for not doing so.

@BriDavidson BriDavidson self-assigned this May 17, 2024
@JakeLo123 JakeLo123 added the enhancement New feature or request label May 17, 2024
Copy link
Collaborator

@JakeLo123 JakeLo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@JakeLo123 JakeLo123 merged commit fc6db17 into main May 17, 2024
3 checks passed
@JakeLo123 JakeLo123 deleted the 46-add-post-logout-redirect-uri-to-SDK-configs branch June 3, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants