Add nuxt to devdependencies #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelyons
changed the title
dmackinn
reviewed
Jun 17, 2024
michaelyons
changed the title
dmackinn
approved these changes
Jun 17, 2024
JakeLo123
requested changes
Jun 17, 2024
JakeLo123
requested changes
Jun 17, 2024
packages/sdk-vue/src/types.ts
Outdated
| @@ -54,10 +54,10 @@ export interface FusionAuthConfig { | |||
| onAutoRefreshFailure?: (error: Error) => void; | |||
|
|
|||
| /** | |||
| * Pass in `useCookie` from nuxt/app [useCookie](https://nuxt.com/docs/api/composables/use-cookie). | |||
| * Pass in `useCookieType` from nuxt/app [useCookie](https://nuxt.com/docs/api/composables/use-cookie). | |||
There was a problem hiding this comment.
This comment shouldn't be changed because the thing they need to pass in is still called useCookie
| @@ -1,5 +1,5 @@ | |||
| import { Ref } from 'vue'; | |||
| import { UseCookie } from './createFusionAuth/NuxtUseCookieAdapter'; | |||
| import { useCookie as useCookieType } from 'nuxt/app'; | |||
There was a problem hiding this comment.
We don't need to import as here because there's no name collision in this file.
JakeLo123
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR and why do we need it?
This PR adds
nuxtto thedevDependenciesto give users the true type definition ofuseCookiefromnuxtinstead of describing the type ourselves.Pre-Merge Checklist (if applicable)