Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

122 Add E2E Documentation #126

Merged
merged 6 commits into from
Jun 17, 2024
Merged

122 Add E2E Documentation #126

merged 6 commits into from
Jun 17, 2024

Conversation

BriDavidson
Copy link
Collaborator

What is this PR and why do we need it?

This PR adds documentation on how to run the existing end-to-end tests for the FA SDK using Playwright. The documentation includes instructions for setting up the environment, running the tests, and maintaining the tests. It ensures that developers can easily execute the tests and understand the underlying configurations and dependencies.

Pre-Merge Checklist (if applicable)

  • Unit and Feature tests have been added/updated for logic changes, or there is a justifiable reason for not doing so.

@BriDavidson BriDavidson self-assigned this Jun 17, 2024
@BriDavidson BriDavidson linked an issue Jun 17, 2024 that may be closed by this pull request
Copy link
Collaborator

@JakeLo123 JakeLo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting to just add those line breaks where I commented please. The other comments are just suggestions.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@BriDavidson BriDavidson requested a review from JakeLo123 June 17, 2024 19:30
@JakeLo123 JakeLo123 merged commit 459c0bb into main Jun 17, 2024
3 checks passed
@JakeLo123 JakeLo123 deleted the 122-add-e2e-documentation branch June 17, 2024 19:44
@JakeLo123 JakeLo123 added the documentation Improvements or additions to documentation label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E documentation
2 participants