Expose factory from Vue SDK #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
michaelyons
approved these changes
Jun 18, 2024
JakeLo123
force-pushed
the
104-vuenuxt-expose-plugin-instancefactory
branch
from
f173271 to
a431246
Compare
BriDavidson
reviewed
Jun 18, 2024
JakeLo123
force-pushed
the
104-vuenuxt-expose-plugin-instancefactory
branch
from
a431246 to
25c6797
Compare
BriDavidson
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR and why do we need it?
#104
This is to expose the
createFusionAuth--factory previously not an exported member of the module. This will make the plugin more flexible in terms of how users want to instantiate it.This makes it possible to instantiate fusionauth outside of the plugin, passing in the instance. See #104 for the original suggestion.
We'll follow this up with a README update to include an example, but it shouldn't be merged until the next version is released. PR Here
Testing
You should be able to import
createFusionAuthfrom the module. This PR adds an example of how to set up a nuxt plugin with the factory, if you'd like to try--though it's not necessarily in the scope of this PR) Here's the nuxt app I've been using.This is not a nuxt-specific change, just something that is probably only helpful to nuxt users.
Pre-Merge Checklist (if applicable)