-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic Userinfo to createFusionAuth for vue sdk #143
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9d37bf5
Add generic Userinfo to createFusionAuth for vue sdk
michaelyons 78f7a9d
Extend generic type into user info
michaelyons 4f40662
Add back generic to create fusion auth
michaelyons 4d19151
Remove extends to fix implementation bugs
michaelyons 11c820e
Extract injection key type
michaelyons f45308f
Allow for other instance values while instantiating FA instance
michaelyons File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,11 @@ describe('createFusionAuth', () => { | |
}); | ||
|
||
it('Fetches userInfo', async () => { | ||
const user = { given_name: 'JSON', family_name: 'Bourne' }; | ||
const user = { | ||
given_name: 'JSON', | ||
family_name: 'Bourne', | ||
customTrait: 'additional info', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason for this change? I believe we can use this test to cover what we're implementing here, but I'm not sure this is doing it. Here's an example |
||
}; | ||
const mockUserInfoResponse = new Response(JSON.stringify(user), { | ||
status: 200, | ||
}); | ||
|
@@ -45,6 +49,7 @@ describe('createFusionAuth', () => { | |
await fusionAuth.getUserInfo(); | ||
|
||
expect(fusionAuth.userInfo.value).toEqual(user); | ||
expect(fusionAuth.userInfo.value.customTrait).toEqual(user.customTrait); | ||
}); | ||
|
||
it('Handles a failed user info request', async () => { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1 @@ | ||
import { InjectionKey } from 'vue'; | ||
import type { FusionAuth } from './types.ts'; | ||
|
||
export const fusionAuthKey = Symbol('fusionAuth') as InjectionKey<FusionAuth>; | ||
export const fusionAuthKey = Symbol('fusionAuth'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
UserInfo
from./types.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#147
Separate issue, though. Here's a ticket #147