Add SDKConfig and SDKContext to core #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeLo123
force-pushed
the
48-consolidate-config-and-context-types
branch
2 times, most recently
from
0d14e53 to
a26a79d
Compare
JakeLo123
force-pushed
the
48-consolidate-config-and-context-types
branch
from
a26a79d to
3b5aca7
Compare
BriDavidson
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR and why do we need it?
#48 - Consolidate SDK config and context via core package.
These definitions will encompass the public API for the next major version release of each SDK.
SDKConfig-- The configuration object needed to initialize each framework's main component.SDKContext-- The values and methods provided by each framework's main component.These types are defined here, not implemented. We are planning to work backwards to get parity for each SDK.
Pre-Merge Checklist (if applicable)