Added aviary-paper-data as LitQA v2 test split
#800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
mskarlin
reviewed
Jan 9, 2025
| litqa_v2 = load_dataset(labbench_dataset, "LitQA2")["train"].to_pandas() | ||
| litqa_v2["distractors"] = litqa_v2["distractors"].apply(list) | ||
| train_eval = load_dataset(train_eval_dataset, "LitQA2")["train"].to_pandas() | ||
| test = load_dataset(test_dataset, "LitQA2")["test"].to_pandas() |
There was a problem hiding this comment.
more of a question for me -- do we validate columns here? (i.e. is distractors checked for explicitly?)
There was a problem hiding this comment.
Thanks to https://github.com/Future-House/paper-qa/blob/v5.9.2/paperqa/agents/task.py#L450-L455, we get:
- Confirmation that column attributes are present
typeguardcan check the types of the values during unit testing, for our defaults
To be clear, I added this comment:
Let downstream usage in the TaskDataset's environment factories check for the
presence of other DataFrame columns
mskarlin
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR title