Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure fields are lists before combining in DocDetails class #801

Merged
merged 20 commits into from
Jan 13, 2025
Merged

Ensure fields are lists before combining in DocDetails class #801

merged 20 commits into from
Jan 13, 2025

Conversation

harryvu-futurehouse
Copy link
Contributor

@harryvu-futurehouse harryvu-futurehouse commented Jan 9, 2025 •
edited
Loading

PR Summary

Fix: Ensure List Format for Merging Fields in DocDetails

This PR ensures that fields within the other dictionary are converted to lists before merging two DocDetails objects. This prevents issues when merging and ensures consistent handling of these fields.

Changes:

  • Ensures fields within the other dictionary are lists before merging.

@harryvu-futurehouse harryvu-futurehouse self-assigned this Jan 9, 2025
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 9, 2025
@harryvu-futurehouse harryvu-futurehouse requested a review from a team January 9, 2025 23:07
jamesbraza
jamesbraza reviewed Jan 9, 2025
View reviewed changes
paperqa/types.py Show resolved Hide resolved
paperqa/types.py Show resolved Hide resolved
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 10, 2025
jamesbraza
jamesbraza reviewed Jan 10, 2025
View reviewed changes
tests/test_task.py Outdated Show resolved Hide resolved
paperqa/types.py Show resolved Hide resolved
tests/test_task.py Outdated Show resolved Hide resolved
jamesbraza
jamesbraza reviewed Jan 10, 2025
View reviewed changes
tests/test_paperqa.py Outdated Show resolved Hide resolved
jamesbraza
jamesbraza reviewed Jan 10, 2025
View reviewed changes
tests/test_paperqa.py Outdated Show resolved Hide resolved
jamesbraza
jamesbraza reviewed Jan 10, 2025
View reviewed changes
tests/test_paperqa.py Outdated Show resolved Hide resolved
tests/test_paperqa.py Outdated Show resolved Hide resolved
jamesbraza
jamesbraza reviewed Jan 10, 2025
View reviewed changes
tests/test_paperqa.py Outdated Show resolved Hide resolved
tests/test_paperqa.py Show resolved Hide resolved
tests/test_paperqa.py Outdated Show resolved Hide resolved
jamesbraza
jamesbraza approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here @harryvu-futurehouse

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 13, 2025
@harryvu-futurehouse harryvu-futurehouse merged commit e5b6447 into main Jan 13, 2025
5 checks passed
@harryvu-futurehouse harryvu-futurehouse deleted the fix-DocDetails branch January 13, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mskarlin mskarlin Awaiting requested review from mskarlin

@jamesbraza jamesbraza Awaiting requested review from jamesbraza

Assignees

@harryvu-futurehouse harryvu-futurehouse

Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harryvu-futurehouse @jamesbraza