Fixing gather_evidence and complete response messages
#812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
whitead
reviewed
Jan 14, 2025
|
can you deploy on dev? Would love to just double-check this |
jamesbraza
force-pushed
the
fixing-tool-messages
branch
from
2750868 to
0375de9
Compare
It works, and I added several expansions to the |
whitead
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two misconceptions:
gather_evidence's response message #809 incorrectly based the relevant docs added count tol0, but it should have only been relevant onescompletetool gets passedhas_successful_answerits response starts with "Success". However, if it turns out the answer is wrong, this response may not make sense. Now the response starts with"Sure""Certain" to be clear