Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clinical trials docs and bugfixes #819

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Clinical trials docs and bugfixes #819

merged 9 commits into from
Jan 17, 2025

Conversation

mskarlin
Copy link
Collaborator

  • Adds a tutorial for using clinical trials, planning on pointing our gitbook to this subdirectory to build out a blog
  • Fixes an issue where a index was being built even if it wasn't needed, we now require a paper_search tool to be included for it to trigger
  • Silenced some warning logs for malformed cookies coming back from clincaltrials.gov, added a utility to do this in general
  • Manually closed sessions that are built on the fly if using the clinical trials search without an external session
  • lowered the cap on clinical trial size truncation a tiny bit given some edge case responses I was seeing in testing

@mskarlin mskarlin requested review from whitead, jamesbraza and a team January 17, 2025 22:31
jamesbraza
jamesbraza reviewed Jan 17, 2025
View reviewed changes
paperqa/sources/clinical_trials.py Outdated Show resolved Hide resolved
paperqa/sources/clinical_trials.py Outdated Show resolved Hide resolved
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working documentation Improvements or additions to documentation labels Jan 17, 2025
jamesbraza
jamesbraza approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

paperqa/utils.py Outdated Show resolved Hide resolved
@mskarlin mskarlin merged commit f0e87e6 into main Jan 17, 2025
6 checks passed
@mskarlin mskarlin deleted the clinical-trials-docs-and-updates branch January 17, 2025 23:13
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbraza jamesbraza jamesbraza approved these changes

@whitead whitead Awaiting requested review from whitead

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mskarlin @jamesbraza