Skip to content

Commit

Permalink
add note comment
Browse files Browse the repository at this point in the history
  • Loading branch information
korewaChino committed Oct 11, 2023
1 parent 658c472 commit 08792c3
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,9 @@ impl IsoBuilder {
cmd_lib::run_cmd!(grub2-mkrescue -o $image $root -volid $volid 2>&1)?;
// todo: normal xorriso command does not work for some reason, errors out with some GPT partition shenanigans
// todo: maybe we need to replicate mkefiboot? (see lorax/efiboot)
// however, while grub2-mkrescue works, it does not use shim, so we still need to manually call xorriso if we want to use shim
// - @korewaChino, cc @madomado
// It works, but we still need to make it use shim somehow
// cmd_lib::run_cmd!(xorriso -as mkisofs -R $[args] -b $bios_bin -no-emul-boot -boot-load-size 4 -boot-info-table -efi-boot-part --efi-boot-image --protective-msdos-label $root -volid $volid -o $image 2>&1)?;
},
_ => {
Expand Down

0 comments on commit 08792c3

Please sign in to comment.