Release the GIL for BytesAhoCorasick when the haystack is bytes
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@itamarst I added a test for checking with different types of haystacks, but I'm not sure if there's an automatic way to tell that the optimised path is taken when the haystack is |
In theory we should do that for every type that is guaranteed to be immutable, in order to improve performance, but there's no way to tell whether a type is immutable or not through the Buffer protocol, so we only do this as a special case for `bytes`. Fixes G-Research#94.
iscgar
force-pushed
the
release_gil_for_bytes_haystack
branch
from
032ab68
to
8994049
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory we should do that for every type that is guaranteed to be immutable, in order to improve performance, but there's no way to tell whether a type is immutable or not through the Buffer protocol, so we only do this as a special case for
bytes.Fixes #94.