Feature/g7 adding slot uri and improvements #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ogarciarevett : Tests are failing. I think it's because you didn't regenerate Python interfaces to the smart contracts. Let me make a script to do that. |
zomglings
reviewed
Jan 30, 2023
There was a problem hiding this comment.
@ogarciarevett : I think we are not on the same page regarding:
- The role of slots on Inventory
- Whether these contracts are just for use by Game7 XP system or whether they are intended for any blockchain game.
Left a few questions for my own understanding. Let us discuss on the PR in case anyone else wants to chime in.
… optional. Missing tests
zomglings
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cant test this using: Laika or directly aiming directly to the smart contract.
tests of the new methods coming ...