Apply suggestions from code review

Co-authored-by: Peter Giles <[email protected]>
GCTC-NTGC · Oct 1, 2024 · 822cc2b · 822cc2b
1 parent 3359bb0
commit 822cc2b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apps/web/src/components/Profile/components/DiversityEquityInclusion/Display.tsx b/apps/web/src/components/Profile/components/DiversityEquityInclusion/Display.tsx
@@ -31,7 +31,7 @@ const Display = ({
   const isIndigenous =
     indigenousCommunities && indigenousCommunities.length > 0;
   const hasClaimedEquityGroup =
-    // Note, we only care about one truthy value so nullish coaliescing seems odd here?
+    // Note, we only care about one truthy value so nullish coalescing is inappropriate here.
     // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
     isWoman || hasDisability || isVisibleMinority || isIndigenous;
 

diff --git a/packages/storybook-helpers/decorators/ThemeDecorator.tsx b/packages/storybook-helpers/decorators/ThemeDecorator.tsx
@@ -56,7 +56,7 @@ const withThemeFromHydrogen = <TRenderer extends Renderer = any>({
   return (storyFn, context) => {
     const selectedTheme = pluckThemeFromContext(context);
     const { themeOverride } = useThemeParameters();
-    const selected = (themeOverride ?? selectedTheme) || defaultTheme;
+    const selected = themeOverride ?? selectedTheme ?? defaultTheme;
 
     const themeArr = useMemo(
       () =>