Skip to content

Commit

Permalink
[Fix] Bookmark column to support null (#9009)
Browse files Browse the repository at this point in the history
* update bookmark migration to be nullable

* update candidate factory to seed some null bookmarks

(cherry picked from commit 212d9b4)
  • Loading branch information
esizer authored and brindasasi committed Jan 15, 2024
1 parent c8f646e commit cd0c274
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion api/database/factories/PoolCandidateFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function definition()
$this->faker->numberBetween(0, count(ApplicationStep::cases()) - 1)
),
'education_requirement_option' => $this->faker->randomElement(EducationRequirementOption::cases())->name,
'is_bookmarked' => $this->faker->boolean(10),
'is_bookmarked' => $this->faker->optional(.8)->boolean(10),
];
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
public function up(): void
{
Schema::table('pool_candidates', function (Blueprint $table) {
$table->boolean('is_bookmarked');
$table->boolean('is_bookmarked')->nullable()->default(null);
});
}

Expand Down

0 comments on commit cd0c274

Please sign in to comment.