Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add expand/collapse all button for advanced filters #10001

Merged
merged 4 commits into from
Apr 15, 2024
Merged

[Feature] Add expand/collapse all button for advanced filters #10001

merged 4 commits into from
Apr 15, 2024

Conversation

esizer
Copy link
Member

@esizer esizer commented Apr 5, 2024

🤖 Resolves #9482

👋 Introduction

Adds a button so users can expand or collapse all advanced filters when on the find talent page.

🧪 Testing

  1. Build pnpm run dev
  2. Navigate to /search
  3. Confirm the button exists next to "Advanced filters"
  4. Confirm it functions as expected:
    • Expands all when none are open
    • Collapses all when at least one is open

📸 Screenshot

screenshot_05-Apr-2024_12-09-1712333374
screenshot_05-Apr-2024_12-09-1712333381

vd1992
vd1992 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@vd1992 vd1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to work fine to me

@mnigh mnigh added the blocked: copy Blocked by missing copy or translations label Apr 9, 2024
@esizer esizer added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit a88599b Apr 15, 2024
12 checks passed
@esizer esizer deleted the 9482-expand-all-advanced-filters branch April 15, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vd1992 vd1992 vd1992 approved these changes

Assignees
No one assigned
Labels
blocked: copy Blocked by missing copy or translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Add "expand all" on the advanced filters on search page
3 participants
@esizer @vd1992 @mnigh