[Debt] Replaces storybook-addon-intl with storybook-react-intl
#10022
Conversation
| @@ -33,15 +33,13 @@ type ThemeSetterProps = { | |||
| theme: Theme; | |||
| }; | |||
| const ThemeSetter = ({ theme }: ThemeSetterProps) => { | |||
| const { setTheme } = useTheme(); | |||
There was a problem hiding this comment.
I don't know if it's as a result of the library change or of this theme change but it seems like Chromatic is taking some snapshots before the components are ready.
For these, the theme icon hasn't yet settled to the right one for the story:
And this one still has the loading spinner running:
There was a problem hiding this comment.
Good 👁️, thanks! As discussed, any of the stories with the ThemeSwitcher component were actually previously incorrect due to the infinite re-render bug in ThemeDecorator where the initial state should have been the system default rather than light mode. The home page I've added a Chromatic delay to the DateInput and Pending stories that should get them to where they should be (more or less). The other diffs are existing issues: #9636, #10025.
packages/storybook-helpers/main.ts
Outdated
There was a problem hiding this comment.
For anyone else who might be confused like me, the switcher is now the globe icon in the toolbar.
🤖 Resolves #10021.
👋 Introduction
This PR replaces
storybook-addon-intlwithstorybook-react-intl.🎩 Acknowledgement
@esizer for stopping the infinite re-render caused by
useEffect.🧪 Testing
Assist reviewers with steps they can take to test that the PR does what it says it does.
pnpm storybook