[Fix] Stabilize srcset in chromatic
#10026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vd1992
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Resolves #9636
👋 Introduction
This may fix an issue with stories that include
img[srcset]being unstable🕵️ Details
I reached out to chromatic suppoer and they suggested preloading assets. I added the
PreloadWebpackPluginto see if that will sort things out. At the same time, I noticed we were not passing a static dir option for static assets so I also added that hoping it might make things a bit more stable 🤷♀️🧪 Testing
Assist reviewers with steps they can take to test that the PR does what it says it does.