Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Debt] Skill and SkillFamily fragment masking #10028

Merged
merged 2 commits into from
Apr 11, 2024
Merged

[Debt] Skill and SkillFamily fragment masking #10028

merged 2 commits into from
Apr 11, 2024

Conversation

esizer
Copy link
Member

@esizer esizer commented Apr 10, 2024

🤖 Resolves #9713

👋 Introduction

Adds top level fragment masking for Skill and SkillFamily queries.

🧪 Testing

Assist reviewers with steps they can take to test that the PR does what it says it does.

  1. Build pnpm run dev
  2. Navigate to pages affected
  3. Confirm they work as expected

@petertgiles petertgiles self-requested a review April 11, 2024 12:38
petertgiles
petertgiles approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I think I'm finally starting to wrap my head around the fragment masking idea.

@esizer
Copy link
Member Author

esizer commented Apr 11, 2024

I think I'm finally starting to wrap my head around the fragment masking idea.

lol I'm, almost there as well! I feel like we are still scratching the surface too 😅

@esizer esizer added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit dedbb1b Apr 11, 2024
12 of 13 checks passed
@esizer esizer deleted the 9713-skill-skill-family-fragments branch April 11, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertgiles petertgiles petertgiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ Implement Skill, SkillFamily fragment masking
2 participants
@esizer @petertgiles