-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Debt] Improve seeding for RoD #10290
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #10290 +/- ##
=============================================
+ Coverage 38.62% 71.11% +32.49%
Complexity 1404 1404
=============================================
Files 994 217 -777
Lines 30555 5439 -25116
Branches 6562 0 -6562
=============================================
- Hits 11801 3868 -7933
+ Misses 18591 1571 -17020
+ Partials 163 0 -163
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
This reverts commit b33243a.
|
||
foreach ($skills->slice(0, 5) as $skill) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed this hard coded skills during pool creation as we need diff no. of skills for the tests.
|
||
GeneralQuestion::factory() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also has been taken out so we can customize the no. of questions per pool
I'm not getting why would this snapshot test fail .
|
This reverts commit d97a986.
hmm .. not sure why this php test would fail all of a sudden .. checking on it |
π€ Resolves #10110
π Introduction
Describe what this PR is solving.
π΅οΈ Details
This PR adds new pools to existing PoolTestSeeder and a new seeder PoolCandidateTestSeeder
This PR also refactors existing code to parameterize skills ,assessments , assessment steps, so we can create as many as we want
I've created the personas as hard coded names & emails instead of random generation from faker. This would be helpful to remember but let me know if team prefers otherwise.
π§ͺ Testing
Assist reviewers with steps they can take to test that the PR does what it says it does.
πΈ Screenshot
Add a screenshot (if possible).