-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add filters to pool table #10423
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10423 +/- ##
============================================
+ Coverage 31.66% 38.42% +6.75%
- Complexity 0 1360 +1360
============================================
Files 776 989 +213
Lines 25046 30421 +5375
Branches 6550 6541 -9
============================================
+ Hits 7930 11688 +3758
- Misses 16941 18711 +1770
+ Partials 175 22 -153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great, and passes manual testing! Just one thing - could you add a test for the classifications scope?
Oops! I totally thought I did that 🤦♀️ Added in add test for classifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
🤖 Resolves #6169
👋 Introduction
Adds filters to the
PoolTable
for streams, statuses, publishing groups and classifications.🧪 Testing
Assist reviewers with steps they can take to test that the PR does what it says it does.
pnpm run dev
[email protected]
/admin/pools
📸 Screenshot