Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add filters to pool table #10423

Merged
merged 6 commits into from
May 21, 2024
Merged

[Feature] Add filters to pool table #10423

merged 6 commits into from
May 21, 2024

Conversation

esizer
Copy link
Member

@esizer esizer commented May 16, 2024

🤖 Resolves #6169

👋 Introduction

Adds filters to the PoolTable for streams, statuses, publishing groups and classifications.

🧪 Testing

Assist reviewers with steps they can take to test that the PR does what it says it does.

  1. Build pnpm run dev
  2. Login as [email protected]
  3. Navigate to the pools table /admin/pools
  4. Use the filter dialog
  5. Confirm it functions as expected

📸 Screenshot

screenshot_16-May-2024_15-01-1715886089

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 24.39024% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 38.42%. Comparing base (844b5f4) to head (2f64fd7).

Files Patch % Lines
...ools/IndexPoolPage/components/PoolFilterDialog.tsx 0.00% 23 Missing ⚠️
...c/pages/Pools/IndexPoolPage/components/helpers.tsx 0.00% 20 Missing ⚠️
...pages/Pools/IndexPoolPage/components/PoolTable.tsx 0.00% 18 Missing ⚠️
api/app/Models/Pool.php 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10423      +/-   ##
============================================
+ Coverage     31.66%   38.42%   +6.75%     
- Complexity        0     1360    +1360     
============================================
  Files           776      989     +213     
  Lines         25046    30421    +5375     
  Branches       6550     6541       -9     
============================================
+ Hits           7930    11688    +3758     
- Misses        16941    18711    +1770     
+ Partials        175       22     -153     
Flag Coverage Δ
integrationtests 70.65% <95.23%> (?)
unittests 31.59% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tristan-orourke tristan-orourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, and passes manual testing! Just one thing - could you add a test for the classifications scope?

@esizer
Copy link
Member Author

esizer commented May 21, 2024

Code looks great, and passes manual testing! Just one thing - could you add a test for the classifications scope?

Oops! I totally thought I did that 🤦‍♀️ Added in add test for classifications

Copy link
Member

@tristan-orourke tristan-orourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@esizer esizer added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 8787448 May 21, 2024
9 of 10 checks passed
@esizer esizer deleted the 6169-add-filters-pool-table branch May 21, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Add 'Publishing group' filter to 'Pools' table
3 participants