-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Debt] Invert stored notification settings #10430
Conversation
Thanks for jumping on this so quickly! Unfortunately, I'm working to merge two more notifications that will need a similar change as the one you made to api/app/Notifications/ApplicationDeadlineApproaching.php. Could we hold the merge on this one until #10372 is in? |
Of course, added the blocked: dependencies label and put the ticket number in the description to make it visible 👍 |
Thanks for waiting. 🙏 It's been merged now. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10430 +/- ##
============================================
- Coverage 38.62% 38.61% -0.01%
- Complexity 1404 1408 +4
============================================
Files 994 995 +1
Lines 30555 30570 +15
Branches 6562 6557 -5
============================================
+ Hits 11801 11805 +4
- Misses 18591 18732 +141
+ Partials 163 33 -130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! I just did code rethrough and flagged a few things to check.
🤖 Resolves #10227
👋 Introduction
Updates the existing notifications values to invert it form ignored to enabled.
🧪 Testing
Assist reviewers with steps they can take to test that the PR does what it says it does.
make refresh-api
pnpm run dev
🛑 Blockers