Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debt] Updates Azure Pipelines ubuntu image #10431

Merged
merged 6 commits into from
May 22, 2024
Merged

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented May 21, 2024

πŸ€– Resolves #10202.

πŸ‘‹ Introduction

This PR updates the Azure Pipeline vmImage to use the same version of Ubuntu as the GitHub action worklfows.

πŸ•΅οΈ Details

Because the GitHub runner ubuntu-22.04 only includes a single version of PHP, version 8.1, which is different from what is currently used by us, version 8.2, a PPA is required in order to install a different version of PHP along with its extensions.

πŸ§ͺ Testing

Assist reviewers with steps they can take to test that the PR does what it says it does.

  1. Deploy in Azure to dev vertical
  2. Verify PHP version 8.2 is installed and app works as it did before the PPA

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 71.11%. Comparing base (844b5f4) to head (6c53789).
Report is 6 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main   #10431       +/-   ##
=============================================
+ Coverage     31.66%   71.11%   +39.45%     
- Complexity        0     1404     +1404     
=============================================
  Files           776      217      -559     
  Lines         25046     5439    -19607     
  Branches       6550        0     -6550     
=============================================
- Hits           7930     3868     -4062     
+ Misses        16941     1571    -15370     
+ Partials        175        0      -175     
Flag Coverage Ξ”
integrationtests 71.11% <ΓΈ> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@mnigh mnigh requested a review from petertgiles May 22, 2024 14:12
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Seems to work great. Just one small change recommended.

infrastructure/bin/set_php_versions.sh Outdated Show resolved Hide resolved
@mnigh mnigh added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 184aa34 May 22, 2024
6 checks passed
@mnigh mnigh deleted the 10202-azure-pipeline-image-php branch May 22, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Bump build pipeline to use Ubuntu 22.04 image
3 participants