Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Claim verification model #10434

Merged
merged 15 commits into from
May 23, 2024
Merged

[Feature] Claim verification model #10434

merged 15 commits into from
May 23, 2024

Conversation

vd1992
Copy link
Contributor

@vd1992 vd1992 commented May 21, 2024

🤖 Resolves #10417

👋 Introduction

Add the required fields via migration, set values for existing candidates, schema update, a mutation, and factory tweaks

I think I got the spirit of the issue.

🧪 Testing

May need to adjust permissions before testing locally, I found /graphiql was acting odd for me

  1. Test migration before seeding data off this branch
  2. Test mutation
mutation poolcandidateClaim {
  updatePoolCandidateClaimVerification(
    id: "e4233336-ea7b-453d-b2bb-2dcb3f577289", 
    poolCandidate: {
      veteranVerification: UNVERIFIED,
    	veteranVerificationExpiry: null,
    	priorityVerification: ACCEPTED,
    	priorityVerificationExpiry: "2025-01-01",
    }
  ) {
    id
    veteranVerification
    veteranVerificationExpiry
    priorityVerification
    priorityVerificationExpiry
  }
}

📸 Screenshot

image

image

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.17%. Comparing base (0eb66cd) to head (9da6401).
Report is 1 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main   #10434       +/-   ##
=============================================
+ Coverage     38.61%   71.17%   +32.55%     
- Complexity     1408     1417        +9     
=============================================
  Files           995      219      -776     
  Lines         30570     5464    -25106     
  Branches       6560        0     -6560     
=============================================
- Hits          11805     3889     -7916     
+ Misses        18731     1575    -17156     
+ Partials         34        0       -34     
Flag Coverage Δ
integrationtests 71.17% <100.00%> (+0.08%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines -122 to +124
'armed_forces_status' => $this->faker->randomElement(ArmedForcesStatus::cases())->name,
'armed_forces_status' => $this->faker->boolean() ?
ArmedForcesStatus::NON_CAF->name
: $this->faker->randomElement(ArmedForcesStatus::cases())->name,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before 2/3 of users were current/past armed forces which seemed a bit egregiously high. This small tweak just halves it.

@petertgiles petertgiles self-requested a review May 22, 2024 12:45
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! 💪 Thanks for the phpunit tests and test queries.

I just finished the readthrough and it's looking great but I think it's missing a few things - mostly my fault. 😢

api/database/factories/PoolCandidateFactory.php Outdated Show resolved Hide resolved
api/tests/Feature/PoolCandidateUpdateTest.php Outdated Show resolved Hide resolved
api/graphql/schema.graphql Show resolved Hide resolved
@vd1992 vd1992 changed the title 10417 claim verification model [Feature] Claim verification model May 22, 2024
@vd1992 vd1992 requested a review from petertgiles May 22, 2024 18:42
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great!

@vd1992 vd1992 added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 0f6d236 May 23, 2024
7 checks passed
@vd1992 vd1992 deleted the 10417-claim-verification-model branch May 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Claim Verification - Data Model
3 participants