Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Profile about section completeness #10441

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented May 22, 2024

🤖 Resolves #10435.

👋 Introduction

This PR adds back fields that are needed in the DashboardHeadingUser fragment.

🦴 Bonus

704cb76: Removes a duplicate key (preferredLanguageForInterview) and adds in a missing key, preferredLanguageForExam, for the aboutSectionHasEmptyRequiredFields validator function.

🧪 Testing

Assist reviewers with steps they can take to test that the PR does what it says it does.

  1. pnpm build
  2. Create a user account
  3. Navigate to /applicant
  4. Observe incomplete status (red) on Personal and contact info item
  5. Navigate to /applicant/personal-information#about-section
  6. Fill in required fields and submit form
  7. Navigate to /applicant
  8. Observe complete status (green) on Personal and contact info item

📸 Screenshot

Screen Shot 2024-05-22 at 14 42 06

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 38.62%. Comparing base (0c04b6e) to head (525784d).
Report is 1 commits behind head on main.

Files Patch % Lines
apps/web/src/validators/profile/about.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10441   +/-   ##
=========================================
  Coverage     38.62%   38.62%           
  Complexity     1404     1404           
=========================================
  Files           994      994           
  Lines         30555    30553    -2     
  Branches       6562     6567    +5     
=========================================
  Hits          11801    11801           
+ Misses        18591    18587    -4     
- Partials        163      165    +2     
Flag Coverage Δ
integrationtests 71.11% <ø> (ø)
unittests 31.58% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mnigh mnigh added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit eefc55a May 23, 2024
9 of 10 checks passed
@mnigh mnigh deleted the 10435-fix-profile-complete branch May 23, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Profile dashboard completion at a glance
3 participants