Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add dev dependencies to Azure build pipeline #10921

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

petertgiles
Copy link
Contributor

🤖 Resolves #10886

👋 Introduction

This branch adds the ability to include the dev dependencies when deploying to Azure. Rather than creating a new pipeline, I added a runtime parameter to the existing pipeline.

The one thing I'm not sure about is how the trigger will work. I hope the default value will be used but we'll find out when it gets merged. 😅 If it doesn't work we can manually trigger the pipeline when needed until the change gets backed out.

🧪 Testing

  1. Run the Azure Pipeline in dev mode
  2. Deploy to an app service
  3. SSH in and try a factory in Tinker

📸 Screenshot

image

image

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.50%. Comparing base (ee57e1d) to head (622a4c3).
Report is 22 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main   #10921       +/-   ##
=============================================
+ Coverage     38.90%   68.50%   +29.59%     
  Complexity     1722     1722               
=============================================
  Files          1054      274      -780     
  Lines         31245     6287    -24958     
  Branches       6570        0     -6570     
=============================================
- Hits          12157     4307     -7850     
+ Misses        19054     1980    -17074     
+ Partials         34        0       -34     
Flag Coverage Δ
integrationtests 68.50% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brindasasi brindasasi self-requested a review July 10, 2024 14:27
Copy link
Contributor

@brindasasi brindasasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yayy.. I'm able to run all the seeders in dev.
Also it was easy to change it to usual prod build mode.
Great work !👏
Thanks Peter!

@petertgiles petertgiles added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 3ad1ef4 Jul 11, 2024
6 checks passed
@petertgiles petertgiles deleted the 10886-fix-dev-deploy branch July 11, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Can no longer deploy artifact with dev dependencies
3 participants