Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Community relation to Pools #11070

Merged
merged 32 commits into from
Jul 30, 2024
Merged

[Feature] Add Community relation to Pools #11070

merged 32 commits into from
Jul 30, 2024

Conversation

vd1992
Copy link
Contributor

@vd1992 vd1992 commented Jul 25, 2024

🤖 Resolves #10364

👋 Introduction

Adds a relation between pools and communities.
This included a migration, factory/seeding tweaks, schema and mutation updates, testing changes, and lastly frontend additions.

🧪 Testing

  1. Test migration forward and back, with and without data
  2. Can create a pool

📸 Screenshot

image

🚚 Deployment

vd1992 added 22 commits July 24, 2024 12:02
vd1992
vd1992 commented Jul 25, 2024
View reviewed changes
api/graphql/schema.graphql Outdated Show resolved Hide resolved
tristan-orourke
tristan-orourke requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@tristan-orourke tristan-orourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few minor suggestions to look at while I manually test it

api/app/Policies/PoolPolicy.php Outdated Show resolved Hide resolved
api/app/Policies/UserPolicy.php Outdated Show resolved Hide resolved
api/tests/Feature/PoolCandidatesPaginatedTest.php Outdated Show resolved Hide resolved
@tristan-orourke
Copy link
Member

Manual testing looks good 👍

tristan-orourke
tristan-orourke requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@tristan-orourke tristan-orourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one suggestion and one required change for the scope

api/tests/Feature/PoolCandidatesPaginatedTest.php Outdated Show resolved Hide resolved
api/app/Models/PoolCandidate.php Outdated Show resolved Hide resolved
tristan-orourke
tristan-orourke approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@tristan-orourke tristan-orourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, looks good!

@vd1992 vd1992 added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit e0bb7ef Jul 30, 2024
12 checks passed
@vd1992 vd1992 deleted the 10364-pool-community-relation branch July 30, 2024 15:05
@brindasasi brindasasi mentioned this pull request Jul 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristan-orourke tristan-orourke tristan-orourke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Add Community relation to Pools
2 participants
@vd1992 @tristan-orourke