[Feature] Communities break apart on the update user page #11584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/web/src/pages/Users/UpdateUserPage/components/AddCommunityRoleDialog.tsx
Outdated
Show resolved
Hide resolved
tristan-orourke
requested changes
Oct 1, 2024
apps/web/src/pages/Users/UpdateUserPage/components/AddCommunityRoleDialog.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/pages/Users/UpdateUserPage/components/AddProcessRoleDialog.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/pages/Users/UpdateUserPage/components/AddProcessRoleDialog.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/pages/Users/UpdateUserPage/components/AddProcessRoleDialog.tsx
Show resolved
Hide resolved
apps/web/src/pages/Users/UpdateUserPage/components/CommunityRoleTable.tsx
Show resolved
Hide resolved
apps/web/src/pages/Users/UpdateUserPage/components/EditCommunityRoleDialog.tsx
Outdated
Show resolved
Hide resolved
|
So far, I have some suggestions on improving readability, but nothing that blocks functionality! |
Co-authored-by: tristan-orourke <[email protected]>
tristan-orourke
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Resolves #10632
👋 Introduction
Incorporates the community changes, so process and community tables in the edit user page. Plus the ability to make role changes.
Stretched the issue a bit by adjusting style/copy of the individual/team tables to keep things in sync. Given the team table will likely go away soon-ish, I didn't stress too much about it.
Thanks for whoever worked on the stuff I recycled to get this done fast, #grateful 🙇
🧪 Testing
/en/admin/users/:id/edit📸 Screenshot