Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debt] Improve RoD seeding some more #11617

Merged
merged 6 commits into from
Sep 27, 2024
Merged

Conversation

vd1992
Copy link
Contributor

@vd1992 vd1992 commented Sep 25, 2024

🤖 Resolves #10165

👋 Introduction

Updates the seeder more per instruction. Also updates the key in enums as well as runs a migration to keep the prod values in sync.

🧪 Testing

  1. Run make seed-fresh
  2. Check out some candidates
  3. Observe the migration

@vd1992 vd1992 changed the title [DebtImprove RoD seeding some more [Debt] Improve RoD seeding some more Sep 25, 2024
@brindasasi brindasasi self-requested a review September 26, 2024 14:50
Copy link
Contributor

@brindasasi brindasasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change needed .. other than that looks good!

Copy link
Contributor

@brindasasi brindasasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vd1992 vd1992 added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 271196f Sep 27, 2024
7 checks passed
@vd1992 vd1992 deleted the 10165-improve-RoD-seeding-more branch September 27, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Improve seeding for RoD some more
2 participants