Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Only throw errors #11661

Merged
merged 2 commits into from
Oct 2, 2024
Merged

[Fix] Only throw errors #11661

merged 2 commits into from
Oct 2, 2024

Conversation

esizer
Copy link
Member

@esizer esizer commented Sep 27, 2024

πŸ€– Resolves #11378

πŸ‘‹ Introduction

Updates our throws to use custom errors instead of hijacking the response.

πŸ•΅οΈ Details

This had to tweak our error boundary to use Errors instead of Responses. Though, you could get an error response so we have to handle that as well (even though we don't directly use them).

πŸ§ͺ Testing

  1. Bujild pnpm run dev:fresh
  2. Confirm explicit throws still render the appropriate error messages
  3. Confirm no lint errors

Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works well.

apps/web/src/components/Router.tsx Outdated Show resolved Hide resolved
@esizer esizer added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 821a53f Oct 2, 2024
11 checks passed
@esizer esizer deleted the 11378-only-throw-errors branch October 2, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Only throw error
2 participants