-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Update manager dashboard UI #11667
Conversation
β¦t - everything should be x1 apart
β¦light); I found the lighter color wasn't contrasty enough
β¦lt, and the bullets should be hidden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β¦, as the card already provides it
Ah, that was the last one, thanks! |
Shoot, looks like that last change broke a bunch of stuff in the Chromatic diff. I'll have to take another look at it. |
@yonikid15 OK, I think I have a solution: To be honest, I don't love it but I can't think of a better way. I wish the accordion didn't have so much padding built into it. π€· |
apps/web/src/pages/ManagerDashboardPage/ManagerDashboardPage.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Yoni K <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π
π€ Resolves #11575
π Introduction
This branch corrects (almost) all the items from Josh's design review of the manager dashboard page.
π΅οΈ Details
Note that one AC was not done:
I think it's already correct:
π§ͺ Testing