-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Bookmark pool candidates #8767
Conversation
apps/web/src/components/AssessmentStepTracker/AssessmentResults.tsx
Outdated
Show resolved
Hide resolved
…s.tsx Add apostrophe to translation Co-authored-by: Matt <[email protected]>
apps/web/src/components/AssessmentStepTracker/AssessmentResults.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/AssessmentStepTracker/AssessmentResults.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, it's looking great! 🌟 I've noted a few things to check on.
apps/web/src/components/AssessmentStepTracker/AssessmentResults.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/AssessmentStepTracker/AssessmentResults.tsx
Outdated
Show resolved
Hide resolved
Had a quick review:
|
I've made the changes mentioned as well as adding sorting by name since I realized I'd missed that. I'm not a huge fan of the new test though since it feels kind of hard to follow. |
Also @Jerryescandon are active members of the armed forces considered veterans in terms of priority/ordering? It looks like we treat them the same as non members right now and I'd like to make sure that's right. |
That sounds correct, I believe only the third option should trigger a priority change: |
Awesome! Thank you! |
🤖 Resolves #8598
👋 Introduction
Adds the ability to bookmark pool candidates in the assessment step tracker.
🧪 Testing
The assessment step tracker is currently not used on any page so testing must be done in storybook.
📸 Screenshot