Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Debt] Add non-nullable marker to query poolCandidates #8854

Merged
merged 1 commit into from
Dec 22, 2023
Merged

[Debt] Add non-nullable marker to query poolCandidates #8854

merged 1 commit into from
Dec 22, 2023

Conversation

vd1992
Copy link
Contributor

@vd1992 vd1992 commented Dec 20, 2023

🤖 Resolves #8820

👋 Introduction

Adds the marker to require a non-null input (array of something).

🧪 Testing

  1. Build unaffected
  2. Can exercise the pool candidates table and nothing changed

@petertgiles petertgiles requested review from petertgiles and mnigh and removed request for petertgiles December 21, 2023 17:34
@petertgiles
Copy link
Contributor

@mnigh Could you please review this one?

esizer
esizer approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! 🍭

@vd1992 vd1992 added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit d636e6c Dec 22, 2023
10 checks passed
@vd1992 vd1992 deleted the 8820-query-non-nullable-input branch December 22, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esizer esizer esizer approved these changes

@mnigh mnigh Awaiting requested review from mnigh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ poolCandidates GraphQL query missing non-null type modifier
3 participants
@vd1992 @petertgiles @esizer