[Debt] Remove applicant filters query #8975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertgiles
reviewed
Jan 10, 2024
| @@ -98,73 +100,6 @@ protected function filterToCreateInput(ApplicantFilter $filter) | |||
| return $input; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Is it worth repointing these tests at poolCandidateSearchRequest.applicantFilter instead of removing them? Or am I misunderstanding how this works?
There was a problem hiding this comment.
I noticed that the test testFilterCanBeStoredAndRetrievedWithoutChangingResults() was querying an applicant filter so I thought why not move the test there and save some space. However, I think your right looking back at it now since it's querying for all the fields which makes for a stronger test. I'll make the changes now 👍
There was a problem hiding this comment.
Oh wow, that was a bit more work than just repointing the tests. 😬 Thanks for pushing through! 🥇
yonikid15
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Resolves #7654
👋 Introduction
applicantFilterquery🧪 Testing
Assist reviewers with steps they can take to test that the PR does what it says it does.