[Feature] Radio button, Divider 페이지 마크업 #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Size Change: 0 B Total Size: 680 kB ℹ️ View Unchanged
|
hamo-o
requested review from
eugene028,
SeieunYoo and
soulchicken
as code owners
SeieunYoo
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
저번 회의 때 저희 서비스 이미지는 복잡하지 않아서(애니메이션, 그라데이션 같은..) svg 로 해도 큰 렌더링 이슈는 생기지 않을 거 같다는 의견이 있었는데 우선 svg 확장자로 통일해보면 어떨까요?!
Comment on lines
+20
to
+24
| <Title | ||
| main="Radio button" | ||
| sub="사용자가 선택할 수 있는 항목 중 하나만 선택할 수 있는 컴포넌트입니다." | ||
| variant="header" | ||
| /> |
There was a problem hiding this comment.
p4;
pageData 에 있는 데이터를 사용하는 게 유지보수 측면에서 좋을 거 같아요~!!
| @@ -0,0 +1,40 @@ | |||
| import type { Item } from "@components/ImageCards"; | |||
|
|
|||
| export const PCItems: Item[] = [ | |||
There was a problem hiding this comment.
p4;
camel case 로 통일하는 게 좋을 거 같아요~
soulchicken
approved these changes
Jan 20, 2025
| </Text> | ||
| <Space height={20} /> | ||
| <Card> | ||
| <RadioGroup defaultValue="selected"> |
There was a problem hiding this comment.
just ask; 라디오 태그를 써볼 일이 없어서 신기합니다! 라디오 그룹에서 라디오 버튼 좌측 3개랑 우측 3개가 같이 불이 들어오는건 의도하신건가용?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
Radio button페이지,Dvider페이지 마크업합니다.🙏 여기는 꼭 봐주세요!
key값을 스프레드 연산자로 넘기면 경고가 발생하여, 직접 넘기도록 수정했습니다. 명시적으로 표기하는 게 좋다고 합니다.ImageCards에서도 이미지 경로가 유니크 한 값이라고 판단하여key로 넘겨주었습니다.