-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Checkbox 컴포넌트 구현 #36
Conversation
… into feature/check-box-component
… into feature/check-box-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿 수고 많으셨어요!
제가 보기엔 고칠 게 많이 없는 거 같네요.. 👍
아래 몇 가지만 추가로 해주시면 좋지 않을까 해요!
- 루트 styled-system 폴더 삭제
- icons 패키지 UpArrow 삭제 (예시로 넣어둔거라...)
그리고 Switch 컴포넌트에도 useCheckedState 훅 적용해보신다고 하셨는데, Checkbox props 보니까 몇 가지 추가하면 좋은 게 있는데 제가 그거 추가하면서 같이 적용해봐도 괜찮을까요?
@ghdtjgus76 리뷰 전부 반영해두었습니당~ Switch 컴포넌트는 따로 수정하지 않을게욥! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 전부 반영해두었습니다!! |
넵 좋습니다! |
아항 CheckBox 도 그룹 형태로 쓰려면 SwitchGroup PR 에서 만드신 Group 컴포넌트를 사용해서 감싸주어야 합니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤸♂️
🎉 변경 사항
inputProps
를 추가합니다.🚩 관련 이슈
🙏 여기는 꼭 봐주세요!
useCheckedState
라는 훅으로 분리해서 체크박스 컴포넌트에는 적용해보았는데 괜찮다면 Switch 컴포넌트에도 적용해보겠습니닷🔗참고자료