Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Box 컴포넌트 구현 #45

Merged
merged 20 commits into from
Jun 23, 2024
Merged

[Feature] Box 컴포넌트 구현 #45

merged 20 commits into from
Jun 23, 2024

Conversation

eugene028
Copy link
Collaborator

@eugene028 eugene028 commented Jun 8, 2024

🎉 변경 사항

Box 컴포넌트를 구현했습니다!
width:100%가 기본이고, 최대 길이만 한정해두었습니다.
leftElement로 자유롭게 사진, 아이콘 등을 첨부할 수 있어요!

스크린샷 2024-06-08 오후 11 33 30

🚩 관련 이슈

Copy link
Contributor

github-actions bot commented Jun 8, 2024

Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 수고하셨습니다...!

packages/wow-icons/src/react/RightArrow.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/Box.stories.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/Box.stories.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@hamo-o hamo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요 !!! 👍

packages/wow-tokens/src/color.ts Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니당 🤗

packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요!
스토리북 문서화 부분도 같이 추가해주시면 감사하겠습니다...

packages/wow-ui/src/components/Box/Box.stories.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/Box.stories.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/panda.config.ts Outdated Show resolved Hide resolved
packages/scripts/generateTokenList.ts Outdated Show resolved Hide resolved
packages/scripts/generateTokenList.ts Outdated Show resolved Hide resolved
packages/scripts/generateTokenList.ts Outdated Show resolved Hide resolved
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨어요~~ 저는 미리 어푸룹 날려봅니다..👍

packages/wow-ui/src/components/Box/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 진짜 수고 많으셨어요...

@eugene028 eugene028 merged commit 08934fa into main Jun 23, 2024
3 checks passed
@eugene028 eugene028 deleted the feature/box-component branch June 23, 2024 15:25
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants