박세찬(B) Spring JPA and H2 Datebase #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why JSON can't be returned?
mjj111
approved these changes
Jul 13, 2024
| @SpringBootTest | ||
| class BackendBeginner2ApplicationTests { | ||
|
|
||
| @Test |
There was a problem hiding this comment.
작성한 코드가 의도치않게 동작한다면, 사전에 테스트 코드를 작성하여 동작상태에서 차츰 리펙토링을 하는 방식으로 구현할 수 있습니다 ! TDD에 대해 학습해서 테스트코드에 대한 필요성과 이득을 얻었으면 좋겠네용
| Course course = courseRepository.findById(courseId).orElseThrow(); | ||
|
|
||
| Enrollment enrollment = new Enrollment(); | ||
| enrollment.setStudent(student); |
There was a problem hiding this comment.
SET 함수는 조오오금 위험합니다 ㅎ
해당 객체가 갖고있는 내부 변수들에 대해 알고, 더불어 하나씩 주입해주고 있는 것은 객체지향적이지 않죠!
차라리, 생성시에 필요한 데이터를 가진 DTO를 전달해줌으로 SET을 줄일 수 있지 않을까요 ?
|
|
||
| public Enrollment enrollStudent(int studentId, int courseId) { | ||
| Student student = studentRepository.findById(studentId).orElseThrow(); | ||
| Course course = courseRepository.findById(courseId).orElseThrow(); |
There was a problem hiding this comment.
예외에 대해 그냥 Throw해버리는 것뿐만아니라 AOP를 활용해서 예외에 대한 응답을 커스텀해서 클라이언트에게 줄 수 있으면 좋을 것 같아요!
|
|
||
| Enrollment savedEnrollment = enrollmentRepository.save(enrollment); | ||
| logger.info("Created enrollment: {}", savedEnrollment); | ||
| return savedEnrollment; |
There was a problem hiding this comment.
만약 저장된 객체가 반환되지 않았다면... 해당 enrollmentRepository.save(enrollment);을 갖고 있는 enrollStudent 메서드가 정상 동작했는지에 대한 테스트 코드가 있으면 좋지 않을까요?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H2 데이터베이스 연결 확인
resource의 data.sql과 schema.sql를 통해 미리 student와 course 테이블을 생성하고 데이터를 넣었습니다.
왜 JSON이 반환이 안될까요???? 뭘 놓치고 있는 걸까요???
특정 학생의 수강과목 추가
_왜 Postman으로 반환되는 결과가 안보일까요? _
수강 과목 삭제
특정 학생의 수강 과목 조회
로그를 통해서 확인했을 때 Enrollment 객체 정보가 제대로 안나오는 것 같은데 뭔가 놓치고 있는 기초 개념이 있는 것 같아요....