Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[팀 C - 이예슬] 1차 코드 리뷰 요청 #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mimpie
Copy link

@mimpie mimpie commented Nov 26, 2023

기능은 모두 구현하였으나 예외처리가 되어있지않고 반복되는 부분이 많습니다. 추후 리팩토링을 거쳐 수정하겠습니다.

@surplus-dev
Copy link

surplus-dev commented Nov 26, 2023

image
77번 라인에서 가격이랑 현재 투입액 동일 할 때 끝나지 않는 문제 있는 것이랑 미구현된 부분 빼면 잘 짜신 것 같습니다
-> 해당 부분은 제가 반대로 잘못 읽은 것 같습니다 죄송합니다

클래스 기반으로 바꿔보면 더 좋을 것 같습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants