ZZZ #14
Open
ZZZ #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuyh99
approved these changes
Nov 26, 2023
| final String USER_INPUT = "사용자 입력 > "; | ||
| final String LINE = "----------------------------"; | ||
|
|
||
| Scanner sc = new Scanner(System.in); |
| System.out.println(); | ||
| System.out.print("사용자 입력 > "); | ||
|
|
||
| int select_Payment_Method = sc.nextInt(); |
There was a problem hiding this comment.
자바 컨벤션을 따르면
Suggested change
| int select_Payment_Method = sc.nextInt(); | |
| int paymentMethod = scanner.nextInt(); |
처럼 될 것 같아요!
| int select_Payment_Method = sc.nextInt(); | ||
| System.out.println(); | ||
| System.out.println("----------------------------"); | ||
| if(select_Payment_Method != 1 || select_Payment_Method != 2) |
There was a problem hiding this comment.
이 코드를 처음 본 사람은 1이나 2가 무엇을 의미하는 지 바로 알아차리기 어려울 것 같은데요!
매직넘버를 상수화 해도 좋을 것 같네요!
| return 1000; | ||
| else if (select_Cash == 5) | ||
| return 500; | ||
| else if (select_Cash == 6) |
There was a problem hiding this comment.
여기 까지 도달하는 조건은 위의 모든 조건이 false라는 전제 조건을 가지고 있어요.
그렇다면 select_Cash == 6 이라는 조건을 수정하려면 위의 모든 코드들을 살펴봐야 합니다.
빠른 리턴을 해서 줄인다면 더 좋을 것 같아요!
|
|
||
|
|
||
|
|
||
| } |
huhdy32
reviewed
Nov 26, 2023
| int selectDrinkTemperature() { | ||
| int selectNumber = userSelectNumber(); | ||
| while(true) { | ||
| if (selectNumber != 1 || selectNumber != 2) { |
There was a problem hiding this comment.
수정이 필요해 보입니다!
selectNumber != 1 && selectNumber != 2 로 바꾸는것이 좋아보이네요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.