Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update persistence qc #227

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update persistence qc #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions src/pypromice/qc/persistence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import logging
from typing import Mapping, Optional, Union, List, TypedDict

import numpy as np
import pandas as pd
import xarray as xr
from typing import Mapping, Optional, Union

__all__ = [
"persistence_qc",
Expand All @@ -14,17 +14,25 @@

logger = logging.getLogger(__name__)

DEFAULT_VARIABLE_THRESHOLDS = {
"t": {"max_diff": 0.0001, "period": 2},
"p": {"max_diff": 0.0001, "period": 2},

class FilterConfig(TypedDict):
variable: str # Regular expression for selecting variable
max_diff: float
period: int


DEFAULT_VARIABLE_THRESHOLDS: List[FilterConfig] = [
{"variable": "^t_[uil]$", "max_diff": 0.0001, "period": 2},
{"variable": "^p_i$", "max_diff": 0.0001, "period": 2},
{"variable": "^p_[ul]$", "max_diff": 0.0001, "period": 24},
# Relative humidity can be very stable around 100%.
#"rh": {"max_diff": 0.0001, "period": 2},
}
# "rh": {"max_diff": 0.0001, "period": 2},
]


def persistence_qc(
ds: xr.Dataset,
variable_thresholds: Optional[Mapping] = None,
variable_thresholds: Optional[List[FilterConfig]] = None,
) -> xr.Dataset:
"""
Detect and filter data points that seems to be persistent within a certain period.
Expand Down Expand Up @@ -60,14 +68,11 @@ def persistence_qc(

logger.debug(f"Running persistence_qc using {variable_thresholds}")

for k in variable_thresholds.keys():
var_all = [
k + "_u",
k + "_l",
k + "_i",
] # apply to upper, lower boom, and instant
max_diff = variable_thresholds[k]["max_diff"] # loading persistent limit
period = variable_thresholds[k]["period"] # loading diff period
for config in variable_thresholds:
var_all = df.filter(regex=config["variable"]).columns
logger.info('Apply filter "{}" on {}'.format(config, var_all))
max_diff = config["max_diff"] # loading persistent limit
period = config["period"] # loading diff period

for v in var_all:
if v in df:
Expand Down
Loading