Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rh_*_cor to rh_*_wrt_ice_or_water #311

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

BaptisteVandecrux
Copy link
Member

No description provided.

@BaptisteVandecrux BaptisteVandecrux changed the title update rh_*_cor to rh_'_wrt_ice_or_water update rh_*_cor to rh_*_wrt_ice_or_water Nov 8, 2024
PennyHow
PennyHow previously approved these changes Nov 11, 2024
Copy link
Member

@PennyHow PennyHow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this all looks good Baptiste. I just checked that all instances of rh_u_cor, rh_l_cor and rh_i_cor were changed. The adjustments to the resampling also are logical and work how they are meant to. Feel free to merge.

PennyHow
PennyHow previously approved these changes Nov 12, 2024
@BaptisteVandecrux BaptisteVandecrux merged commit 5d312ac into develop Nov 12, 2024
3 checks passed
@BaptisteVandecrux BaptisteVandecrux deleted the feature/rename-rh_cor branch November 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants