Skip to content

Commit

Permalink
fix(init): prevent module from configuring the logger
Browse files Browse the repository at this point in the history
  • Loading branch information
SlowMo24 authored Oct 25, 2024
1 parent 9dbcaea commit 86d2948
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 18 deletions.
16 changes: 10 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# Changelog

## Unreleased
## [Unreleased](https://github.com/GIScience/ohsome-py/compare/v0.3.3..master)

## 0.3.3
### Fixed

- the module configuring the root logger on import causing users to be forced to overwrite the configuration.

## [0.3.3](https://github.com/GIScience/ohsome-py/releases/tag/v0.3.3)

### Fixed

Expand All @@ -17,7 +21,7 @@

- init variable `data` to `OhsomeResponse`

## 0.3.2
## [0.3.2](https://github.com/GIScience/ohsome-py/releases/tag/v0.3.2)

### Fixed

Expand All @@ -28,7 +32,7 @@
- if tags are supplied for explosion in `response.as_dataframe`, the respective column will always be present in the resulting Geodataframe, even if the tags were not part of the result. In that case the column will be all-None ([#149](https://github.com/GIScience/ohsome-py/issues/149)).


## 0.3.1
## [0.3.1](https://github.com/GIScience/ohsome-py/releases/tag/v0.3.1)

### Fixed

Expand All @@ -41,7 +45,7 @@
- improved and sped up testing (first steps towards [#139](https://github.com/GIScience/ohsome-py/issues/139))
- move metadata property from singleton to `cached_property`

## 0.3.0
## [0.3.0](https://github.com/GIScience/ohsome-py/releases/tag/v0.3.0)

### Added

Expand All @@ -63,7 +67,7 @@
- support for pandas < 2.1
- support for urllib3 < 2.1

## 0.2.0
## [0.2.0](https://github.com/GIScience/ohsome-py/releases/tag/v0.2.0)

### Added

Expand Down
11 changes: 4 additions & 7 deletions ohsome/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,7 @@

"""Ohsome API client for Python"""

from .exceptions import OhsomeException
from .response import OhsomeResponse
from .clients import OhsomeClient
import logging

log_format = "%(asctime)s %(module)8s %(levelname)5s: %(message)s"
logging.basicConfig(level="INFO", format=log_format)
# The order of imports here must remain to prevent circular imports
from .exceptions import OhsomeException # noqa
from .response import OhsomeResponse # noqa
from .clients import OhsomeClient # noqa
5 changes: 0 additions & 5 deletions ohsome/test/__init__.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-
"""__description__"""

import logging

log_format = "%(asctime)s %(module)8s %(levelname)5s: %(message)s"
logging.basicConfig(level="DEBUG", format=log_format)

0 comments on commit 86d2948

Please sign in to comment.