Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support different python objects in list2string concat #120

Merged
merged 7 commits into from
Nov 16, 2023

Conversation

SlowMo24
Copy link
Collaborator

closes #111

@SlowMo24 SlowMo24 marked this pull request as draft November 14, 2023 13:27
@SlowMo24 SlowMo24 requested a review from redfrexx November 15, 2023 16:12
@SlowMo24 SlowMo24 marked this pull request as ready for review November 15, 2023 16:13
Copy link
Member

@redfrexx redfrexx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Just one potential error and some doc string descriptions are missing.

ohsome/helper.py Outdated Show resolved Hide resolved
ohsome/test/test_client.py Show resolved Hide resolved
ohsome/helper.py Outdated Show resolved Hide resolved
@SlowMo24 SlowMo24 requested a review from redfrexx November 16, 2023 11:15
@SlowMo24 SlowMo24 merged commit b7f5b5b into master Nov 16, 2023
4 checks passed
@SlowMo24 SlowMo24 deleted the fix_list_concat branch November 16, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for type in list
3 participants