-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check timestamp with tz #132
Conversation
So the ohsome API always returns a timestamp with timezone (i.e. the Z in the end). ohsome-py returned timestamp objects without timezone in the functions where |
…the response for a dataframe and geodataframe
…rames(geoemtry) and geodataframes(groupByBoundary) is with timezone(UTC). Than the format parameter for every timestamp in the function _as_geodataframe was changed to ISO8601
1da1c7b
to
fd700b5
Compare
I favour timestamps without time-zone. I never had a benefit only nuisance. For example you can note time zones differently (e.g. As you say: "everything is in UTC" so there is no benefit in marking that fact explicitly. |
…the response for a dataframe and geodataframe
…rames(geoemtry) and geodataframes(groupByBoundary) is with timezone(UTC). Than the format parameter for every timestamp in the function _as_geodataframe was changed to ISO8601
fd700b5
to
6a31938
Compare
True, I forgot about the 3.10 issue. Then let's have the timestamp without time zones. @rp280 can you adapt the code accordingly? |
…e/ohsome-py into check_timestamp_with_TZ
… is returning the same timestamp string without the character Z. Also the code was adjusted to remove the character z in the timestamp string
…s removed and a new test to check the contributions.count.density.groupByBoundary.post output was written
A Test for Issue #121 was also created in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress. Please update the CHANGELOG and state explicitely that we are deviating from the ohsome api here
… a reference to changelog
…nd readme were rewinded
No description provided.