fix(BaseClient): prevent raising an error if None is passed to the log_dir

[SlowMo24]

No description provided.

[maciej-adamiak]

The code is fine and fulfills the requirements of the proposed change. On the other hand, I wonder why you decided not to assert the correctness of the declared log directory by requiring it to be an optional Path instead of the optional string.

[SlowMo24]

The code is fine and fulfills the requirements of the proposed change. On the other hand, I wonder why you decided not to assert the correctness of the declared log directory by requiring it to be an optional Path instead of the optional string.

@maciej-adamiak the current approach is that we will forcefully create the path if it does not exist:

ohsome-py/ohsome/clients.py

Lines 59 to 60 in 289f4c5

	if self.log:
	self.log_dir.mkdir(parents=True, exist_ok=True)