Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helper): GeoSeries not working as bpolys input #158

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

SlowMo24
Copy link
Collaborator

Closes #155

@SlowMo24 SlowMo24 requested a review from redfrexx June 27, 2024 13:34
@SlowMo24 SlowMo24 self-assigned this Jun 27, 2024
Copy link
Contributor

@matthiasschaub matthiasschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments which could be addressed but do not need to. Some are unrelated to the PR (For those should I create issues?).

Otherwise, the PR looks good :)

ohsome/helper.py Outdated Show resolved Hide resolved
ohsome/helper.py Show resolved Hide resolved
ohsome/helper.py Show resolved Hide resolved
Co-authored-by: Matthias (~talfus-laddus) <[email protected]>
@SlowMo24 SlowMo24 merged commit addb892 into master Jul 4, 2024
4 checks passed
@SlowMo24 SlowMo24 deleted the 155-geoseries-for-bpolys branch July 4, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: using GeoSeries as bpolys parameter raises TypeError
2 participants